Repository navigation
仙台空港アクセス線の廃止済み快速の削除を本番へ反映する - #1727
Merged
Merged
Conversation
🚉 停車駅の変更1 件の削除された停車パターン
🗑️ 快速 (Rapid) - 仙台空港線 / 東北本線type_cd=102, line_group_cd=958 変更内容: 9 駅削除 |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
仙台空港アクセス線の廃止済み快速の削除(#1726)を、dev から master(本番)へ反映します。
変更の種類
変更内容
data/5!station_station_types.csvから快速系統line_group_cd=958の9行を削除します。master へのマージで本番デプロイが実行され、更新データを埋め込んだWorkerが再構築されます。
テスト
make fmtが通ることmake clippyが通ること(wasm32 ターゲットを含む)make testが通ること上記は元PR #1726 に記録された実行結果です。本番PR作成時のローカル再実行は行っていません。
make test:514件成功、既存の手動性能比較1件をignore。cargo test -p data_validator --test sendai_airport_access:3件成功。cargo run -p data_validator:[VALID] No errors reported.。make check:native / wasm32 とも成功。関連Issue
Refs #1726
スクリーンショット(任意)